DO NOT MERGE!!!! - New access control #33
+104
−73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE !!!! - setting this pull request up to track updates that need to happen before it is ready
Scope:
This PR overhauls how access control is handled in Curator.sol. It allows a user to initialize their own access control pattern via an external contract, that can use arbitrary logic as long as it is compatible with this interface. The accessControl pattern that has been set up is generic and can be used in any smart contract, and this curation protocol will be the first to use it
To Dos Before Merging:
Questions to answer before merging:
5. Think we should push a "DefaultAccessControl.sol" file that can be used without an accessControlInitializer in the factory to provide a generic, onlyOwner based access control strategy. This can then be used as the default access control that is triggered if ppl pass the address(0) value + empty accessControlInitializer into the CuratorFactory 6. *not related to upgrade* - CurationFactory uses the variable “ address curationManger” to initialize the owner of the proxy curation contract. Feels potentially confusing? Do we change it to curationContractOwner maybe? Dont really like that either...